Merge fb_long_identifiers changes into fb_databaseidentifier#880
Merged
labkey-adam merged 4 commits intofb_databaseidentifierfrom Apr 30, 2025
Merged
Merge fb_long_identifiers changes into fb_databaseidentifier#880labkey-adam merged 4 commits intofb_databaseidentifierfrom
labkey-adam merged 4 commits intofb_databaseidentifierfrom
Conversation
|
ERROR: A pull request from |
labkey-matthewb
added a commit
that referenced
this pull request
May 1, 2025
* DatabaseIdentifier ColumnInfo.getAlias() ColumnInfo.getSelectName() * DatabaseIdentifier.getString() -> getid() some fuzz testing * search for "+ col.getAlias() +" (implicit .toString()) * getProperties() * replace .get(column.getAlias()) * StringBuilder->SQLFragment also assert in DatabaseIdentifier.toString() to find teamcity failures * StringBuilder->SQLFragment * Merge fb_long_identifiers changes into fb_databaseidentifier (#880) --------- Co-authored-by: Adam Rauch <adam@labkey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Merging the long identifiers changes into the database identifiers feature branch: #876 --> #873